Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-9909][Agent] Add unit test for installer #9916

Merged
merged 13 commits into from
Apr 3, 2024
Merged

[INLONG-9909][Agent] Add unit test for installer #9916

merged 13 commits into from
Apr 3, 2024

Conversation

justinwwhuang
Copy link
Contributor

[INLONG-9909][Agent] Add unit test for installer

Motivation

Add unit test for installerntext, and why you're making that change. What is the problem you're trying to solve?*

Modifications

Add unit test for installer

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@justinwwhuang justinwwhuang added this to the 1.12.0 milestone Apr 2, 2024
@justinwwhuang justinwwhuang self-assigned this Apr 2, 2024
@justinwwhuang @aloyszhang
Update inlong-agent/agent-installer/src/main/java/org/apache/inlong/a…
a53d8a5 
…gent/installer/ModuleManager.java

Co-authored-by: AloysZhang <[email protected]>
aloyszhang
aloyszhang approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dockerzhang dockerzhang merged commit 30dd38f into apache:master Apr 3, 2024
8 checks passed
@justinwwhuang justinwwhuang deleted the b9909 branch April 7, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloyszhang aloyszhang aloyszhang approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

@haifxu haifxu Awaiting requested review from haifxu

Assignees

@justinwwhuang justinwwhuang

Labels
component/agent
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

[Improve][Agent] Add unit test for installer
3 participants
@justinwwhuang @dockerzhang @aloyszhang