Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-9980][Manager] Remove the derby.jar file from the manager project #9981

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

hnrainll
Copy link
Contributor

@hnrainll hnrainll commented Apr 13, 2024

Prepare a Pull Request

Motivation

The manager project does not use derby.jar, and the inclusion of derby.jar in the project may add new security shares, so remove it.

@hnrainll hnrainll changed the title [Improve][Manager] Remove the derby.jar file from the manager project [INLONG-9980][Manager] Remove the derby.jar file from the manager project Apr 13, 2024
@dockerzhang
Copy link
Contributor

@hnrainll thanks for your contribution, please add the Motivation for the reason to remote the jar , thanks.

@hnrainll
Copy link
Contributor Author

@hnrainll thanks for your contribution, please add the Motivation for the reason to remote the jar , thanks.

I have updated Motivation.

The manager project does not use derby.jar, and the inclusion of derby.jar in the project may add new security shares, so remove it.

Copy link
Contributor

@vernedeng vernedeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dockerzhang dockerzhang merged commit 0fee4a1 into apache:master Apr 15, 2024
10 of 11 checks passed
@hnrainll hnrainll deleted the INLONG-9980 branch April 15, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Remove the derby.jar file from the manager project
5 participants