-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAK-8413 Use the new Azure SDK in the Azure Segment Store #1748
Open
ierandra
wants to merge
20
commits into
apache:trunk
Choose a base branch
from
ierandra:issue/OAK-8413
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,497
−1,244
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7e3dfc0
OAK-8413 Use the new Azure SDK in the Azure Segment Store
ierandra 35ddcfa
Merge branch 'trunk' of https://github.com/ierandra/jackrabbit-oak in…
ierandra 75edd07
OAK-8413 Use the new Azure SDK in the Azure Segment Store - configure…
ierandra 2768330
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review…
ierandra f98b20b
OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests
ierandra 9718bbc
OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests
ierandra a125e1e
OAK-8413 Use the new Azure SDK in the Azure Segment Store - remove de…
ierandra 18db288
Merge branch 'trunk' of https://github.com/ierandra/jackrabbit-oak in…
ierandra 43df254
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review…
ierandra 045b4dd
OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootP…
ierandra 3ccdb10
OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootP…
ierandra 427ca79
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review
ierandra a33dd37
OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootP…
ierandra 931cc3b
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review
ierandra 6374860
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review
ierandra 12c5eae
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review
ierandra ffe0f40
Merge branch 'trunk' of https://github.com/ierandra/jackrabbit-oak in…
ierandra 84180d8
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge
ierandra 871294b
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge
ierandra d236a3c
OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review
ierandra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arer we embedding the new SDK? Why?
(We embedded the old one due to the Guava dependency issue, but this should not be needed here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried without and I got the following error at build:
[ERROR] Bundle oak-segment-azure:1.71-ierandra-T20241104112150-3ccdb109e0 is importing package(s) com.azure.xml in start level 15 but no bundle is exporting these for that start level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the oak-it-osgi tests? In which case we may have to add the dependency there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, when building CQ: https://jenkins-evergreen.ci.corp.adobe.com/job/Sprouts/job/aemcs-developer-releases/5335/artifact/1-BuildAEM.log