Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPGRADE] Netty 4.1.110 => 4.1.118 #2638

Closed
wants to merge 2 commits into from
Closed

[UPGRADE] Netty 4.1.110 => 4.1.118 #2638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7441a6c
[UPGRADE] Netty 4.1.110 => 4.1.118
chibenwa Feb 11, 2025
5a70e6a
fixup! [UPGRADE] Netty 4.1.110 => 4.1.118
Arsnael Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@
<junit.platform.version>1.10.2</junit.platform.version>
<junit.vintage.version>5.10.2</junit.vintage.version>
<concurrent.version>1.3.4</concurrent.version>
<netty.version>4.1.110.Final</netty.version>
<netty.version>4.1.118.Final</netty.version>
<cucumber.version>7.15.0</cucumber.version>

<jackson.version>2.17.1</jackson.version>
Expand Down
2 changes: 1 addition & 1 deletion server/blob/blob-s3/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<name>Apache James :: Server :: Blob :: S3</name>

<properties>
<s3-sdk.version>2.26.5</s3-sdk.version>
<s3-sdk.version>2.29.52</s3-sdk.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point upgrading to an outdated and also vulnerable version of netty...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we need this alignment between netty and s3)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me a while to write the reason of why. First of all, as explained below, those two versions seem to have the same version of netty, as link pasted to the code source, aka 4.1.115. So I don't see how your change is addressing the CVE on this side.

Second, upgrading to 2.30.17 (that is aligned with the correct version of netty) implies serious breaking changes, as explained below, that requires being careful and proper testing before jumping in.

</properties>

<dependencies>
Expand Down