Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17816: Add testRuntimeOnly runtimeTestLibs to test-common-api module #17523

Merged
merged 2 commits into from
Oct 18, 2024
Merged

KAFKA-17816: Add testRuntimeOnly runtimeTestLibs to test-common-api module #17523

merged 2 commits into from
Oct 18, 2024

Conversation

mingyen066
Copy link
Contributor

Changes

  • Add testRuntimeOnly runtimeTestLibs to test-common-api module
  • Use implementation libs.junitJupiterApi instead of implementation libs.junitJupiter in module test-common-api

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Oct 17, 2024
chia7712
chia7712 reviewed Oct 17, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
m1a2st
m1a2st approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingyen066 Thanks for the fix, LGTM

@chia7712 chia7712 merged commit d9cbbcf into apache:trunk Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1a2st m1a2st m1a2st approved these changes

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
build Gradle build or GitHub Actions ci-approved small Small PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mingyen066 @chia7712 @m1a2st @frankvicky