KAFKA-17625: Removing explicit ZK test parameterizations #17638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccabe
approved these changes
Oct 30, 2024
chia7712
approved these changes
Oct 30, 2024
This reverts commit 296031f.
|
|
LGTM, thanks. Committed. |
abhishekgiri23
pushed a commit
to abhishekgiri23/kafka
that referenced
this pull request
Nov 5, 2024
This PR removes ZK test parameterizations from ducktape by: - Removing zk from quorum.all_non_upgrade - Removing quorum.zk from @matrix and @parametrize annotations - Changing usages of quorum.all to quorum.all_kraft - Deleting message_format_change_test.py The default metadata_quorum value still needs to be changed to KRaft rather than ZK, but this will be done in a follow-up PR. Reviewers: Kirk True <[email protected]>, Colin P. McCabe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes ZK test parameterizations from ducktape by:
zkfromquorum.all_non_upgradequorum.zkfrom@matrixand@parametrizeannotationsquorum.alltoquorum.all_kraftmessage_format_change_test.pyThe default
metadata_quorumvalue still needs to be changed to KRaft rather than ZK, but this will be done in a follow-up PR.This approach was discussed here: #17601 (comment)
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)