MINOR: Various cleanups in clients #17895
Open
+199
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
force-pushed
the
clients-cleanups
branch
from
3aa4100
to
db11286
Compare
TaiJuWu
approved these changes
Nov 22, 2024
Comment on lines
-386
to
-388
| } catch (UnsupportedEncodingException e) { | ||
| // The world has gone crazy! | ||
| throw new IOException(String.format("Encoding %s not supported", StandardCharsets.UTF_8.name())); |
There was a problem hiding this comment.
Just out of curiosity, all linux distributions aleady support utf-8?
There was a problem hiding this comment.
This exception can be thrown by URLEncoder.encode(String, String) when the 2nd argument is not a valid charset. Since Java 10, there's a new method encode(String, Charset). We can now use this new method and pass StandardCharsets.UTF_8, which is a Charset object directly instead of StandardCharsets.UTF_8.name which is a String. That way we are sure encode(String, Charset) won't throw UnsupportedEncodingException.
|
@mimaison please fix the conflicts, thanks ! |
mimaison
force-pushed
the
clients-cleanups
branch
from
db11286
to
5cb4206
Compare
|
Done! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)