KAFKA-19220: Add tests to ensure the internal configs don't return by public APIs by default #19650
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
m1a2st
reviewed
May 6, 2025
| } | ||
|
|
||
| private void assertNotContainsInternalConfig(Config config, Map<String, ConfigDef.ConfigKey> configKeyMap, | ||
| Set<String> whiteListSet) { |
There was a problem hiding this comment.
Could you avoid using whiteList, and replace with more neutral terminology.
There was a problem hiding this comment.
Sure, I have changed it, PTAL
FrankYang0529
approved these changes
May 7, 2025
chia7712
reviewed
May 8, 2025
|
|
||
| assertNotNull(configKey); | ||
| if (!ignoreConfigNames.contains(configName)) { | ||
| assertFalse(configKey.internalConfig); |
There was a problem hiding this comment.
Could you please add error message for this assert?
| // broker (see org.apache.kafka.common.test.KafkaClusterTestKit.Builder.createNodeConfig()), | ||
| // so the API `describeConfigs` will also return these three configurations. However, other internal | ||
| // configurations will not be returned | ||
| Config brokerConfig = configResourceMap.get(brokerResource); |
There was a problem hiding this comment.
Could you please verify the internal config for controller node too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check whether the results returned by the API
createTopicsanddescribeConfigscontain internal configurations.