Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6921][AUTHZ] Test CTAS for Paimon #6922

Conversation

davidyuan1223
Copy link
Contributor

@davidyuan1223 davidyuan1223 commented Feb 15, 2025

Why are the changes needed?

AUTHZ Test CTAS for Paimon to check it support this command, the related issue is #6921

How was this patch tested?

Test Authz for paimon with create table as command. Check the permission.

Was this patch authored or co-authored using generative AI tooling?

No

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (51b8e7b) to head (7bfd6ad).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6922   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         688     688           
  Lines       42598   42598           
  Branches     5807    5807           
======================================
  Misses      42598   42598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidyuan1223
Copy link
Contributor Author

@bowenliang123 @pan3793 please review it

@pan3793 pan3793 changed the title support create table as for paimon [KYUUBI ##6921][AUTHZ] Test CTAS for Paimon Feb 16, 2025
@pan3793 pan3793 changed the title [KYUUBI ##6921][AUTHZ] Test CTAS for Paimon [KYUUBI #6921][AUTHZ] Test CTAS for Paimon Feb 16, 2025
Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please complete the PR description template.

Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

…kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala


change test desc

Co-authored-by: Cheng Pan <[email protected]>
@pan3793
Copy link
Member

pan3793 commented Feb 17, 2025

CI fails with Scala 2.13, the Paimon jar seems Scala version dependent, but does not follow the Scala jar name pattern.

@pan3793
Copy link
Member

pan3793 commented Feb 17, 2025

Fix Scala 2.13 test failure in #6925

@davidyuan1223
Copy link
Contributor Author

Fix Scala 2.13 test failure in #6925

Can I start implementing other subtasks?

@pan3793 pan3793 closed this in ed96ac1 Feb 19, 2025
pan3793 pushed a commit that referenced this pull request Feb 19, 2025
### Why are the changes needed?

AUTHZ Test CTAS for Paimon to check it support this command, the related issue is #6921

### How was this patch tested?

Test Authz for paimon with create table as command. Check the permission.

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #6922 from davidyuan1223/support_create_table_as_for_paimon_check.

Closes #6921

7bfd6ad [david yuan] Update extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/PaimonCatalogRangerSparkExtensionSuite.scala
a9ce20c [davidyuan] support create table as for paimon

Lead-authored-by: davidyuan <[email protected]>
Co-authored-by: david yuan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit ed96ac1)
Signed-off-by: Cheng Pan <[email protected]>
@pan3793 pan3793 added this to the v1.10.2 milestone Feb 19, 2025
@pan3793
Copy link
Member

pan3793 commented Feb 19, 2025

Thanks, merged to master/1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants