Fix ConcurrentModificationException in updateLoggers()
#3235
+57
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `InternalLoggerRegistry` implementation introduced in version `2.24.2` did not return a copy of the registry, when `InternalLoggerRegistry.getLoggers()` was called. This could lead to a `ConcurrentModificationException` if a thread creates a new logger, while another thread calls `LoggerContext.updateLoggers()`. Closes #3234
vy
approved these changes
Nov 24, 2024
|
Hi all, Does this mean a 2.24.3 is around the corner? |
@garydgregory, I would wait a couple of weeks to see if other bugs are reported, but, yes, I think we should release a We can also release |
vy
reviewed
Nov 25, 2024
| @@ -513,7 +512,7 @@ public Logger getLogger(final String name) { | |||
| * @return a collection of the current loggers. | |||
| */ | |||
| public Collection<Logger> getLoggers() { | |||
| return loggerRegistry.getLoggers().collect(Collectors.toList()); | |||
| return loggerRegistry.getLoggers(); | |||
There was a problem hiding this comment.
Shouldn't we rather keep the old defensive copy around to avoid similar problems from integrators?
There was a problem hiding this comment.
Collectors.toList() does make a copy, right?
I could add a test for that in case the implementation of InternalLoggerRegistry.getLoggers() changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InternalLoggerRegistryimplementation introduced in version2.24.2did not return a copy of the registry, whenInternalLoggerRegistry.getLoggers()was called. This could lead to aConcurrentModificationExceptionif a thread creates a new logger, while another thread callsLoggerContext.updateLoggers().Closes #3234