Removing all deprecated TopScoreDocCollector + TopFieldCollector methods (#create, #createSharedManager) #13617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ods (#create, #createSharedManager) These are already marked for deprecation in 9.x and we previously removed all internal use of these methods in 10.0.
|
Thanks again @slow-J . Heads up, I moved the changes entry to the "API changes" section above after merging, I did not catch this while reviewing :) |
|
My bad, sorry for the mistake, thanks for catching it and the review! |
no big deal, just a small oversight. Cheers! |
javanna
added a commit
to elastic/elasticsearch
that referenced
this pull request
Aug 28, 2024
…r creation methods See apache/lucene#13617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on: #13500
These methods already marked for deprecation in 9.x and we previously removed all internal use of these methods in 10.0 (in #13500).
Tested with:
./gradlew tidy && ./gradlew testCloses: #13499