Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install correct version with brew. Fixes #1088 #1089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Install correct version with brew. Fixes #1088 #1089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ sense. With SDKMAN!, the `~/.m2/mvnd.properties` file is typically not needed at

[source,shell]
----
$ brew install mvndaemon/homebrew-mvnd/mvnd
$ brew install mvndaemon/homebrew-mvnd/mvnd@1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should target mvnd-1.x branch and not master.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm targeting the README file that appears when you got to the repository. That would the master branch. Should the master branch have instructions that install the pre-release version?

Also, MVND is awesome.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, maybe provide instructions for both then ? and add a comment to explain what that there are two branches.

----

Note: There are two formulae: the `mvnd` that install latest, and `mvnd@1` that installs 1.x line.
Expand Down