Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRESOURCES-284] Support JSON format for parameter filter files #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ImadBL
Copy link

@ImadBL ImadBL commented Apr 25, 2022

Hi,

This concerns the maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT) plugins.
with this evolution it is now possible to add configuration files with json format. the second part of this evolution is to have to use a one configuration json file for all environments (dev, preprod, prod...etc )
for more example check: MRESOURCES-284

please note that you must accept the PR first for maven-filtering (3.3.0-SNAPSHOT)
because maven-resources-plugin (3.2.1-SNAPSHOT) need maven-filtering (3.3.0-SNAPSHOT)

if you have any questions do not hesitate, hoping that I have detailed well

Best regards
Imad BELMOUJAHID
@ImadBL

@elharo elharo changed the title Support JSON format for parameter filter files #MRESOURCES-284 [MRESOURCES-284] Support JSON format for parameter filter files Mar 25, 2023
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more tests. If you want to proceed with this please update to master and add tests. Otherwise it will eventually be closed.

@@ -208,6 +208,14 @@ public class ResourcesMojo
@Parameter
protected LinkedHashSet<String> delimiters;

/**
* This parameter is used in particular for filters properties files with format json.
* if this parameter is not empty, we select all the parameters who are the nodes start with this parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If

@@ -58,41 +61,44 @@ protected File getValidationFile()

/**
* load property test case can be adjusted by modifying the basic.properties and basic_validation properties
* I added a null for this parameter (rootNode) because it is only used with json file @ImadBL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be an API doc comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants