Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm/cxd56: use chip specific vectors to allow smpcall update regs #14363

Merged
merged 5 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions arch/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -1119,6 +1119,13 @@ config ARCH_RAMFUNCS
so that FLASH can be reconfigured while the MCU executes out of
SRAM.

config ARCH_HAVE_CUSTOM_VECTORS
bool
default n
---help---
If ARCH_HAVE_CUSTOM_VECTORS is defined, Chip should provide vectors
table as an optimization.

config ARCH_HAVE_RAMVECTORS
bool
default n
Expand Down
3 changes: 3 additions & 0 deletions arch/arm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ config ARCH_CHIP_LC823450
select ARCH_HAVE_HEAPCHECK
select ARCH_HAVE_MULTICPU
select ARCH_HAVE_I2CRESET
select ARCH_HAVE_CUSTOM_VECTORS
---help---
ON Semiconductor LC823450 architectures (ARM dual Cortex-M3)

Expand Down Expand Up @@ -348,6 +349,7 @@ config ARCH_CHIP_RP2040
select ARM_HAVE_WFE_SEV
select ARCH_HAVE_PWM_MULTICHAN
select ARCH_BOARD_COMMON
select ARCH_HAVE_CUSTOM_VECTORS
---help---
Raspberry Pi RP2040 architectures (ARM dual Cortex-M0+).

Expand Down Expand Up @@ -653,6 +655,7 @@ config ARCH_CHIP_CXD56XX
select ARCH_HAVE_SDIO if MMCSD
select ARCH_HAVE_MATH_H
select ARCH_HAVE_I2CRESET
select ARCH_HAVE_CUSTOM_VECTORS
---help---
Sony CXD56XX (ARM Cortex-M4) architectures

Expand Down
6 changes: 5 additions & 1 deletion arch/arm/src/armv6-m/Make.defs
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,13 @@ CMN_ASRCS += arm_exception.S arm_saveusercontext.S

CMN_CSRCS += arm_cpuinfo.c arm_doirq.c arm_hardfault.c arm_initialstate.c
CMN_CSRCS += arm_schedulesigaction.c arm_sigdeliver.c arm_svcall.c
CMN_CSRCS += arm_systemreset.c arm_tcbinfo.c arm_vectors.c
CMN_CSRCS += arm_systemreset.c arm_tcbinfo.c
CMN_CSRCS += arm_trigger_irq.c

ifneq ($(CONFIG_ARCH_HAVE_CUSTOM_VECTORS),y)
CMN_CSRCS += arm_vectors.c
endif

ifneq ($(filter y,$(CONFIG_DEBUG_FEATURES)$(CONFIG_ARM_COREDUMP_REGION)),)
CMN_CSRCS += arm_dumpnvic.c
endif
Expand Down
6 changes: 5 additions & 1 deletion arch/arm/src/armv7-m/Make.defs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ CMN_CSRCS += arm_hardfault.c arm_initialstate.c arm_itm.c
CMN_CSRCS += arm_memfault.c arm_perf.c
CMN_CSRCS += arm_schedulesigaction.c arm_sigdeliver.c
CMN_CSRCS += arm_svcall.c arm_systemreset.c arm_tcbinfo.c
CMN_CSRCS += arm_trigger_irq.c arm_usagefault.c arm_vectors.c arm_dbgmonitor.c
CMN_CSRCS += arm_trigger_irq.c arm_usagefault.c arm_dbgmonitor.c

ifneq ($(CONFIG_ARCH_HAVE_CUSTOM_VECTORS),y)
CMN_CSRCS += arm_vectors.c
endif

ifeq ($(CONFIG_ARMV7M_SYSTICK),y)
CMN_CSRCS += arm_systick.c
Expand Down
6 changes: 5 additions & 1 deletion arch/arm/src/armv8-m/Make.defs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ CMN_CSRCS += arm_memfault.c arm_perf.c arm_sau.c
CMN_CSRCS += arm_schedulesigaction.c arm_securefault.c arm_secure_irq.c
CMN_CSRCS += arm_sigdeliver.c arm_svcall.c
CMN_CSRCS += arm_systemreset.c arm_tcbinfo.c
CMN_CSRCS += arm_trigger_irq.c arm_usagefault.c arm_vectors.c arm_dbgmonitor.c
CMN_CSRCS += arm_trigger_irq.c arm_usagefault.c arm_dbgmonitor.c

ifneq ($(CONFIG_ARCH_HAVE_CUSTOM_VECTORS),y)
CMN_CSRCS += arm_vectors.c
endif

ifeq ($(CONFIG_ARMV8M_SYSTICK),y)
CMN_CSRCS += arm_systick.c
Expand Down
3 changes: 2 additions & 1 deletion arch/arm/src/cxd56xx/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ set(SRCS
cxd56_icc.c
cxd56_powermgr.c
cxd56_farapi.c
cxd56_sysctl.c)
cxd56_sysctl.c
cxd56_vectors.c)

if(CONFIG_SMP)
list(APPEND SRCS cxd56_cpuidlestack.c)
Expand Down
1 change: 1 addition & 0 deletions arch/arm/src/cxd56xx/Make.defs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ CHIP_CSRCS += cxd56_icc.c
CHIP_CSRCS += cxd56_powermgr.c
CHIP_CSRCS += cxd56_farapi.c
CHIP_CSRCS += cxd56_sysctl.c
CHIP_CSRCS += cxd56_vectors.c

ifeq ($(CONFIG_SMP), y)
CHIP_CSRCS += cxd56_cpuidlestack.c
Expand Down
107 changes: 107 additions & 0 deletions arch/arm/src/cxd56xx/cxd56_vectors.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
/****************************************************************************
* arch/arm/src/cxd56xx/cxd56_vectors.c
*
* Copyright (C) 2012 Michael Smith. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* 3. Neither the name NuttX nor the names of its contributors may be
* used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/

/****************************************************************************
* Included Files
****************************************************************************/

#include <nuttx/config.h>

#include "chip.h"
#include "arm_internal.h"
#include "ram_vectors.h"
#include "nvic.h"

/****************************************************************************
* Private Functions
****************************************************************************/

/* Chip-specific entrypoint */

extern void __start(void);

static void start(void)
{
/* Zero lr to mark the end of backtrace */

asm volatile ("mov lr, #0\n\t"
"b __start\n\t");
}

/****************************************************************************
* Public Functions
****************************************************************************/

/* Common exception entrypoint */

extern void exception_common(void);
extern void exception_direct(void);
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/

#define IDLE_STACK (_ebss + CONFIG_IDLETHREAD_STACKSIZE)

/****************************************************************************
* Public data
****************************************************************************/

/* The cx56 use CXD56_IRQ_SMP_CALL to do SMP call.
* When sig dispatch do up_schedule_sigaction, need to make a new frame to
* run arm_sigdeliver. But the exception_direct cannot handle xcp.regs as we
* did not update the regs when c-function expection handler is called.
*
* We need to use exception_common to handle SMP call.
*/

const void * const _vectors[] locate_data(".vectors")
aligned_data(VECTAB_ALIGN) =
{
/* Initial stack */

IDLE_STACK,

/* Reset exception handler */

start,

/* Vectors 2 - n point directly at the generic handler */

[2 ... NVIC_IRQ_PENDSV] = &exception_common,
[NVIC_IRQ_SYSTICK ... (CXD56_IRQ_SMP_CALL - 1)]
= &exception_direct,
[CXD56_IRQ_SMP_CALL] = &exception_common,
xiaoxiang781216 marked this conversation as resolved.
Show resolved Hide resolved
[(CXD56_IRQ_SMP_CALL + 1) ... (15 + ARMV7M_PERIPHERAL_INTERRUPTS)]
= &exception_direct
};
2 changes: 1 addition & 1 deletion arch/arm/src/lc823450/Make.defs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ include armv7-m/Make.defs

CHIP_CSRCS = lc823450_allocateheap2.c lc823450_start.c lc823450_irq.c lc823450_timer.c
CHIP_CSRCS += lc823450_lowputc.c lc823450_serial.c lc823450_clockconfig.c
CHIP_CSRCS += lc823450_syscontrol.c lc823450_gpio.c
CHIP_CSRCS += lc823450_syscontrol.c lc823450_gpio.c lc823450_vectors.c

# Configuration-dependent LC823450 files

Expand Down
112 changes: 112 additions & 0 deletions arch/arm/src/lc823450/lc823450_vectors.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
/****************************************************************************
* arch/arm/src/lc823450/lc823450_vectors.c
*
* Copyright (C) 2012 Michael Smith. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
*
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
* 3. Neither the name NuttX nor the names of its contributors may be
* used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
* FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
* COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
* OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
* AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/

/****************************************************************************
* Included Files
****************************************************************************/

#include <nuttx/config.h>

#include "chip.h"
#include "arm_internal.h"
#include "ram_vectors.h"
#include "nvic.h"

/****************************************************************************
* Pre-processor Definitions
****************************************************************************/

#define IDLE_STACK (_ebss + CONFIG_IDLETHREAD_STACKSIZE)

/****************************************************************************
* Private Functions
****************************************************************************/

/* Chip-specific entrypoint */

extern void __start(void);

static void start(void)
{
/* Zero lr to mark the end of backtrace */

asm volatile ("mov lr, #0\n\t"
"b __start\n\t");
}

/****************************************************************************
* Public Functions
****************************************************************************/

/* Common exception entrypoint */

extern void exception_common(void);
extern void exception_direct(void);

/****************************************************************************
* Public data
****************************************************************************/

/* The v7m vector table consists of an array of function pointers, with the
* first slot (vector zero) used to hold the initial stack pointer.
*
* As all exceptions (interrupts) are routed via exception_common, we just
* need to fill this array with pointers to it.
*
* Note that the [ ... ] designated initializer is a GCC extension.
*/

const void * const _vectors[] locate_data(".vectors")
aligned_data(VECTAB_ALIGN) =
{
/* Initial stack */

IDLE_STACK,

/* Reset exception handler */

start,

/* Vectors 2 - n point directly at the generic handler */

[2 ... NVIC_IRQ_PENDSV] = &exception_common,
[(NVIC_IRQ_PENDSV + 1) ... (LC823450_IRQ_SMP_CALL_01 - 1)]
= &exception_direct,
[LC823450_IRQ_SMP_CALL_01] = &exception_common,
[(LC823450_IRQ_SMP_CALL_01 + 1) ... (LC823450_IRQ_SMP_CALL_11 - 1)]
= &exception_direct,
[LC823450_IRQ_SMP_CALL_11] = &exception_common,
[(LC823450_IRQ_SMP_CALL_11 + 1) ... (15 + ARMV7M_PERIPHERAL_INTERRUPTS)]
= &exception_direct
};
1 change: 1 addition & 0 deletions arch/arm/src/rp2040/Make.defs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ CHIP_CSRCS += rp2040_pio.c
CHIP_CSRCS += rp2040_clock.c
CHIP_CSRCS += rp2040_xosc.c
CHIP_CSRCS += rp2040_pll.c
CHIP_CSRCS += rp2040_vectors.c

ifeq ($(CONFIG_SMP),y)
CHIP_CSRCS += rp2040_cpustart.c
Expand Down
Loading
Loading