-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix #14761
Conversation
[Experimental Bot, please feedback here] No. The PR is missing critical information required by the NuttX template.
Therefore, the PR in its current state does not meet the NuttX requirements. It needs substantial additions to be considered complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This also fixes recursive panic/assertion for me when trying to take the spinlock from assert!
…ction" This reverts commit 35240d7.
623ca36
to
f4c9338
Compare
@yamt please fix the following warning:
|
Note that SYSLOG_DEFAULT can be used in extreme situations, including very early in the boot.
Summary
Reapply "SYSLOG_DEFAULT: wrap up_putc/up_nputs calls with critical section" with a fix.
original change #14722
a revert #14751
Impact
Testing
(with semaphore: Fix a few regressions #14755 and a few other unrelated local patches)