-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Disable the failed macOS Builds #14772
Conversation
- `sim:libcxxtest`: macOS doesn't support cxxabi.h - `sim:lua`: macOS doesn't support pipe2() - `sim:note`: macOS doesn't support `ld --wrap` - `sim:quickjs`: macOS fails to patch quickjs-libc.c - `sim:rpproxy_virtio`: macOS fails at uintmax_t `unsigned long long` vs `unsigned long` - `sim:rpserver_virtio`: macOS fails at uintmax_t `unsigned long long` vs `unsigned long`
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, though some sections could be more explicitly filled out. Here's a breakdown: Strengths:
Areas for Improvement (While Minor, Worth Considering):
Despite the minor suggestions, the PR provides sufficient information to understand the change, its impact, and the verification process. It generally meets the requirements. |
-Darwin,sim:rpproxy_virtio | ||
|
||
# macOS fails at uintmax_t: 'unsigned long long' vs 'unsigned long' | ||
-Darwin,sim:rpserver_virtio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we fix this problem instead disabling it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm can anyone help? Our macOS builds have been failing in our NuttX Mirror for a couple of weeks, kinda distressing to see it failing the NuttX Mirror Build every day 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you attach the warning message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created the issue:
-Darwin,sim:libcxxtest | ||
|
||
# macOS doesn't support pipe2() | ||
-Darwin,sim:lua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but pipe2 should work in Darwin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something special about the Lua build I think, since the other calls to pipe2 seem OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created the issue:
@@ -33,6 +33,16 @@ | |||
# macOS matter compilation is not currently supported | |||
-Darwin,sim:matter | |||
|
|||
# macOS doesn't support cxxabi.h | |||
-Darwin,sim:libcxxtest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/nuttx/tree/master/libs/libxx/libcxxabi could provide cxxabi.h, can we switch to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry not quite sure how to switch it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll post the above as NuttX Issues, since I'm not able to resolve them. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created the issue
Summary
This PR disables the failed macOS Builds from CI Checks sim-02 and sim-03, so that the macOS CI Checks will complete successfully in the NuttX Mirror Repo:
sim:libcxxtest
: macOS doesn't support cxxabi.hsim:lua
: macOS doesn't support pipe2()sim:note
: macOS doesn't supportld --wrap
sim:quickjs
: macOS fails to patch quickjs-libc.csim:rpproxy_virtio
: macOS fails at uintmax_tunsigned long long
vsunsigned long
sim:rpserver_virtio
: macOS fails at uintmax_tunsigned long long
vsunsigned long
Impact
With this PR, macOS CI Checks will complete successfully in the NuttX Mirror Repo.
Testing
The macOS CI Checks completed successfully in our Test Repo:
https://github.com/lupyuen5/label-nuttx/actions/runs/11828738112