-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spinlock: use inline replace macro #14932
base: master
Are you sure you want to change the base?
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing:
The PR needs to be significantly more detailed to meet the NuttX requirements. Provide specific information for each section to demonstrate a thorough understanding of the change and its impact. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you currently using a compiler that does not support this extension? If not, please keep this implementation, otherwise !Please delete all the code in nuttx that uses this extended syntax
include/nuttx/spinlock.h
Outdated
}) | ||
static inline_function | ||
bool spin_trylock_irqsave_wo_note(FAR volatile spinlock_t *lock, | ||
irqstate_t *flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
irqstate_t *flags) | |
FAR irqstate_t *flags) |
include/nuttx/spinlock.h
Outdated
}) | ||
static inline_function | ||
bool spin_trylock_irqsave_wo_note(FAR volatile spinlock_t *lock, | ||
irqstate_t *flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
irqstate_t *flags) | |
FAR irqstate_t *flags) |
include/nuttx/spinlock.h
Outdated
true : ({ up_irq_restore(f); false; }); \ | ||
}) | ||
static inline_function | ||
bool spin_trylock_irqsave(FAR volatile spinlock_t *lock, irqstate_t *flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool spin_trylock_irqsave(FAR volatile spinlock_t *lock, irqstate_t *flags) | |
bool spin_trylock_irqsave(FAR volatile spinlock_t *lock, FAR irqstate_t *flags) |
include/nuttx/spinlock.h
Outdated
true; \ | ||
}) | ||
static inline_function | ||
bool spin_trylock_irqsave(FAR volatile spinlock_t *lock, irqstate_t *flags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool spin_trylock_irqsave(FAR volatile spinlock_t *lock, irqstate_t *flags) | |
bool spin_trylock_irqsave(FAR volatile spinlock_t *lock, FAR irqstate_t *flags) |
reason: we.avoid.use gcc express statement extension in spinlock, to enhance compatibility Signed-off-by: hujun5 <[email protected]>
OK, Keep it as it is. |
Summary
Impact
spinlock
Testing
ci ostest