Skip to content

Commit

Permalink
refactor: Remove dead services libsql (#5616)
Browse files Browse the repository at this point in the history
Signed-off-by: Xuanwo <[email protected]>
  • Loading branch information
Xuanwo authored Feb 8, 2025
1 parent dafdee1 commit 6e8ebf4
Show file tree
Hide file tree
Showing 17 changed files with 69 additions and 773 deletions.
7 changes: 0 additions & 7 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,6 @@ OPENDAL_GDRIVE_ACCESS_TOKEN=<access_token>
OPENDAL_GDRIVE_REFRESH_TOKEN=<refresh_token>
OPENDAL_GDRIVE_CLIENT_ID=<client_id>
OPENDAL_GDRIVE_CLIENT_SECRET=<client_secret>
# libsql
OPENDAL_LIBSQL_ROOT=/tmp/opendal/
OPENDAL_LIBSQL_CONNECTION_STRING=https://example.com/db
OPENDAL_LIBSQL_AUTH_TOKEN=<secret>
OPENDAL_LIBSQL_TABLE=t_opendal
OPENDAL_LIBSQL_KEY_FIELD=key
OPENDAL_LIBSQL_VALUE_FIELD=val
# sqlite
OPENDAL_SQLITE_CONNECTION_STRING=file:///tmp/opendal/test.db
OPENDAL_SQLITE_TABLE=data
Expand Down
2 changes: 0 additions & 2 deletions bindings/java/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ services-all = [
"services-gridfs",
"services-sqlite",
"services-azfile",
"services-libsql",
"services-swift",
"services-alluxio",
"services-b2",
Expand Down Expand Up @@ -128,7 +127,6 @@ services-hdfs = ["opendal/services-hdfs"]
services-huggingface = ["opendal/services-huggingface"]
services-ipfs = ["opendal/services-ipfs"]
services-koofr = ["opendal/services-koofr"]
services-libsql = ["opendal/services-libsql"]
services-memcached = ["opendal/services-memcached"]
services-mini-moka = ["opendal/services-mini-moka"]
services-moka = ["opendal/services-moka"]
Expand Down
62 changes: 0 additions & 62 deletions bindings/java/src/main/java/org/apache/opendal/ServiceConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -1729,68 +1729,6 @@ public Map<String, String> configMap() {
}
}

/**
* Configuration for service libsql.
*/
@Builder
@Data
@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
class Libsql implements ServiceConfig {
/**
* <p>Connection string for libsql service.</p>
*/
public final String connectionString;
/**
* <p>Authentication token for libsql service.</p>
*/
public final String authToken;
/**
* <p>Table name for libsql service.</p>
*/
public final String table;
/**
* <p>Key field name for libsql service.</p>
*/
public final String keyField;
/**
* <p>Value field name for libsql service.</p>
*/
public final String valueField;
/**
* <p>Root for libsql service.</p>
*/
public final String root;

@Override
public String scheme() {
return "libsql";
}

@Override
public Map<String, String> configMap() {
final HashMap<String, String> map = new HashMap<>();
if (connectionString != null) {
map.put("connection_string", connectionString);
}
if (authToken != null) {
map.put("auth_token", authToken);
}
if (table != null) {
map.put("table", table);
}
if (keyField != null) {
map.put("key_field", keyField);
}
if (valueField != null) {
map.put("value_field", valueField);
}
if (root != null) {
map.put("root", root);
}
return map;
}
}

/**
* Configuration for service memcached.
*/
Expand Down
2 changes: 0 additions & 2 deletions bindings/nodejs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ services-all = [
"services-mongodb",
"services-gridfs",
"services-sqlite",
"services-libsql",
"services-alluxio",
"services-b2",
"services-seafile",
Expand Down Expand Up @@ -126,7 +125,6 @@ services-hdfs = ["opendal/services-hdfs"]
services-huggingface = ["opendal/services-huggingface"]
services-ipfs = ["opendal/services-ipfs"]
services-koofr = ["opendal/services-koofr"]
services-libsql = ["opendal/services-libsql"]
services-memcached = ["opendal/services-memcached"]
services-mini-moka = ["opendal/services-mini-moka"]
services-moka = ["opendal/services-moka"]
Expand Down
2 changes: 0 additions & 2 deletions bindings/python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ services-all = [
"services-mongodb",
"services-gridfs",
"services-sqlite",
"services-libsql",
"services-alluxio",
"services-b2",
"services-seafile",
Expand Down Expand Up @@ -129,7 +128,6 @@ services-hdfs = ["opendal/services-hdfs"]
services-huggingface = ["opendal/services-huggingface"]
services-ipfs = ["opendal/services-ipfs"]
services-koofr = ["opendal/services-koofr"]
services-libsql = ["opendal/services-libsql"]
services-memcached = ["opendal/services-memcached"]
services-mini-moka = ["opendal/services-mini-moka"]
services-moka = ["opendal/services-moka"]
Expand Down
16 changes: 1 addition & 15 deletions bindings/python/python/opendal/__base.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -420,20 +420,6 @@ class _Base:
branch: str = ...,
) -> None: ...

@overload
def __init__(
self,
scheme: Literal["libsql"],
/,
*,
connection_string: str = ...,
auth_token: str = ...,
table: str = ...,
key_field: str = ...,
value_field: str = ...,
root: str = ...,
) -> None: ...

@overload
def __init__(
self,
Expand Down Expand Up @@ -842,4 +828,4 @@ class _Base:


@overload
def __init__(self, scheme: str, /, **kwargs: str) -> None: ...
def __init__(self, scheme: str, /, **kwargs: str) -> None: ...
13 changes: 0 additions & 13 deletions core/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6e8ebf4

Please sign in to comment.