Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/dart): Add dart binding #5591

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Feb 1, 2025

Which issue does this PR close?

Closes #2435. Use the same way as https://github.com/open-spaced-repetition/fsrs-rs-dart.

Rationale for this change

What changes are included in this PR?

add dart binding

Are there any user-facing changes?

no

@asukaminato0721 asukaminato0721 changed the title init add dart binding Feb 1, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review February 1, 2025 11:23
@asukaminato0721 asukaminato0721 changed the title add dart binding feat(bindings/dart): Add dart binding Feb 1, 2025
@asukaminato0721 asukaminato0721 marked this pull request as draft February 1, 2025 15:37
@asukaminato0721
Copy link
Contributor Author

asukaminato0721 commented Feb 1, 2025

I only ported part of the apis so the test can pass. And currently all result is using unwrap (as a first version).

@asukaminato0721 asukaminato0721 marked this pull request as ready for review February 1, 2025 19:38
@Xuanwo
Copy link
Member

Xuanwo commented Feb 2, 2025

Thank you so much, @asukaminato0721, for working on this. I will start reviewing this PR later next week. Wishing you a wonderful holiday in the meantime!

.github/workflows/ci_bindings_dart.yml Outdated Show resolved Hide resolved
.github/workflows/ci_bindings_dart.yml Outdated Show resolved Hide resolved
.github/workflows/ci_bindings_dart.yml Outdated Show resolved Hide resolved
.github/workflows/ci_bindings_dart.yml Outdated Show resolved Hide resolved
bindings/dart/README.md Outdated Show resolved Hide resolved
bindings/dart/lib/src/rust/api/opendal_api.dart Outdated Show resolved Hide resolved
bindings/dart/pubspec.yaml Outdated Show resolved Hide resolved
bindings/dart/pubspec.yaml Outdated Show resolved Hide resolved
licenserc.toml Outdated Show resolved Hide resolved
bindings/dart/rust/src/lib.rs Outdated Show resolved Hide resolved
bindings/dart/lib/src/rust/api/opendal_api.dart Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenDAL Dart/Flutter bindings
2 participants