fix: ghac doesn't support delete anymore #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
tisonkun
approved these changes
Feb 14, 2025
tisonkun
reviewed
Feb 14, 2025
| @@ -59,7 +59,7 @@ jobs: | |||
| - name: Test | |||
| shell: bash | |||
| working-directory: core | |||
| run: cargo nextest run behavior --features tests,services-ghac | |||
| run: cargo test behavior --features tests,services-ghac | |||
There was a problem hiding this comment.
May I ask what's the rationale here?
There was a problem hiding this comment.
Nextest relies on path/to/test/binary list to enumerate all test cases. If any logs are output at this stage, it will refuse to run.
Output likes:
error: creating test list failed
Caused by:
for `opendal::behavior`, line ' 2025-02-14T11:57:30.185063Z DEBUG opendal::services: service=ghac name=opendal: metadata started' did not end with the string ': test' or ': benchmark'
full output:
behavior::test_read_full: test
behavior::test_read_range: test
behavior::test_reader: test
behavior::test_reader_with_if_match: test
behavior::test_reader_with_if_none_match: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5621
Rationale for this change
All deleted related tests are failed for ghac now.
What changes are included in this PR?
Are there any user-facing changes?