feat: Add SchedulerTask which will be notified once cancelled. #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
commented
Dec 16, 2024
actor/src/main/scala/org/apache/pekko/actor/LightArrayRevolverScheduler.scala
Outdated
Show resolved
Hide resolved
He-Pin
force-pushed
the
timer
branch
2 times, most recently
from
db126f1 to
7f4c70c
Compare
|
I'm not sure that we could add this in a v1.1 patch. I'd prefer if we delay this till v1.2.0. |
|
I'm fine with this, but as the current method is add as a default method, it should be fine too. |
pjfanning
reviewed
Dec 28, 2024
actor-tests/src/test/scala/org/apache/pekko/actor/SchedulerSpec.scala
Outdated
Show resolved
Hide resolved
|
I'm quite worried that these tests will be brittle in CI. The CI agents can often suffer from performance issues and tests can take longer to run than on laptops, etc. |
He-Pin
commented
Dec 28, 2024
| /** | ||
| * A Task that will be notified when it is cancelled. | ||
| * | ||
| * @since 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #1579
Tests is still missing