Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract test client for HTTP requests #220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract test client for HTTP requests #220

wants to merge 1 commit into from

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 28, 2024 •
edited
Loading

Description

Extract test client for HTTP requests to simplify tests.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue

@ebyhr ebyhr force-pushed the ebi/test-clietn branch 2 times, most recently from be3f08b to b6874e4 Compare August 28, 2024 12:24
collado-mike
collado-mike previously approved these changes Sep 19, 2024
View reviewed changes
@ebyhr ebyhr requested a review from flyrain as a code owner September 20, 2024 05:49
eric-maynard
eric-maynard reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@eric-maynard eric-maynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this has some conflicts now, and not all tests are covered by the fix. But if you decide to revive this PR let me know, I think this is a great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-maynard eric-maynard eric-maynard left review comments

@collado-mike collado-mike collado-mike left review comments

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@flyrain flyrain Awaiting requested review from flyrain flyrain is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebyhr @eric-maynard @collado-mike