[FEATURE REQUEST] Support endpoints field in the config endpoint #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import org.apache.iceberg.rest.responses.ConfigResponse; | ||
|
|
||
| // TODO: Replace with Iceberg's ConfigResponse after integrating Iceberg 1.7.0 | ||
| // Related PR: https://github.com/apache/iceberg/pull/10929#issuecomment-2418591566 |
There was a problem hiding this comment.
Does it make sense to hold off until 1.7.0?
There was a problem hiding this comment.
Yes, we will hold if off until 17.0 based on the discussion here: #316
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Make a comment to prevent this PR being deleted, still wait for the integration of Iceberg 1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the endpoints field was introduced in Iceberg REST spec recently to describe the server capabilities in
/v1/config, Polaris can align with this change by extending the catalog config API to include the endpoints field.Fixes #316
Included Changes:
rest-catalog-open-api.yamlconfigIcebergCatalogAdapterConfigResponseandResourcePathsas a temp workaround before integrated with Iceberg 1.70TODO
Since the latest changes related to endpoints are not yet released (currently at version 1.6.1) and are planned for release in 1.7.0, we need to replace the two extended classes with the Iceberg's implementations after the upgrade.
Related PR: apache/iceberg#10929
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.