Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure EclipseLink for automatic schema migration #456

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eric-maynard
Copy link
Contributor

Description

After #438 , it was reported that users with an existing metastore might not see the new columns get added to the metastore. This PR configures EclipseLink (via the default persistence.xml) to automatically add new columns when they should appear in the metastore.

Fixes #450

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

With this PR, I have walked through the steps described in #450, and tests are now (mostly) passing:

git checkout e232b000760da335721e9112f9d52fe041289613
rm -rf extension/persistence/eclipselink/build
./gradlew :polaris-eclipselink:test --rerun
git checkout issue-450
./gradlew :polaris-eclipselink:test --rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Potential eclipselink schema upgrade issue
1 participant