[improve][io] KCA: flag to force optional primitive schemas #19951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
force-pushed
the
kca-schema-optional
branch
from
71b4444 to
c688a22
Compare
Codecov Report
@@ Coverage Diff @@
## master #19951 +/- ##
=============================================
+ Coverage 31.88% 72.79% +40.91%
- Complexity 6421 31540 +25119
=============================================
Files 1682 1859 +177
Lines 127354 137175 +9821
Branches 13892 15109 +1217
=============================================
+ Hits 40601 99857 +59256
+ Misses 80714 29357 -51357
- Partials 6039 7961 +1922
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlg99
added a commit
that referenced
this pull request
Mar 29, 2023
Motivation Kafka's schema has "Optional" flag that used there to validate data/allow nulls. Pulsar's schema does not have such info which makes conversion to kafka schema lossy. Modifications Added a config parameter that lets one force primitive schemas into optional ones. KV schema is always optional. Default is false, to match existing behavior. (cherry picked from commit 55523ac)
dlg99
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 29, 2023
…9951) Motivation Kafka's schema has "Optional" flag that used there to validate data/allow nulls. Pulsar's schema does not have such info which makes conversion to kafka schema lossy. Modifications Added a config parameter that lets one force primitive schemas into optional ones. KV schema is always optional. Default is false, to match existing behavior. (cherry picked from commit 55523ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Kafka's schema has "Optional" flag that used there to validate data/allow nulls.
Pulsar's schema does not have such info which makes conversion to kafka schema lossy.
Modifications
Added a config parameter that lets one force primitive schemas into optional ones.
KV schema is always optional.
Default is false, to match existing behavior.
Verifying this change
This change updated tests.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dlg99#12