-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][fn] Support OAuth2 in Go instance #22323
base: master
Are you sure you want to change the base?
[improve][fn] Support OAuth2 in Go instance #22323
Conversation
How do we test this? |
Seems no, there are no OAuth2 tests for python and java instance too, and there is even no |
978e376
to
19d9ab0
Compare
19d9ab0
to
0f0a540
Compare
Hi, IMO The pulsar-client-go testing should ensure the oauth2 is working or not. Pulsar-function should ensure we applied the correct configuration for it. :) So, would you mind adding the configuration applied testing? |
An integration test would also be possible, but that does require effort and knowledge of how Pulsar system level integration tests are developed. |
Added tests for checking the arguments |
Fixes #22322
Main Issue: #xyz
PIP: #xyz
Motivation
The Go instance doesn't support OAuth2 authentication yet, it's better to support it
Modifications
Support the OAuth2 in Go instance
Verifying this change
Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: jiangpengcheng#30