Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8955] Fix message buffer not release and dispatch thread exit in tiered storage #8965

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

lizhimins
Copy link
Member

@lizhimins lizhimins commented Nov 21, 2024

[ISSUE #8955] Fix message buffer not release and dispatch thread exit in tiered storage

Which Issue(s) This PR Fixes

Fixes #8955

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 28 lines in your changes missing coverage. Please review.

Project coverage is 47.60%. Comparing base (9202de3) to head (127e7aa).

Files with missing lines Patch % Lines
...q/tieredstore/core/MessageStoreDispatcherImpl.java 21.73% 16 Missing and 2 partials ⚠️
...che/rocketmq/tieredstore/index/IndexStoreFile.java 69.69% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8965      +/-   ##
=============================================
- Coverage      47.71%   47.60%   -0.12%     
+ Complexity     11771    11748      -23     
=============================================
  Files           1304     1304              
  Lines          91118    91129      +11     
  Branches       11692    11694       +2     
=============================================
- Hits           43477    43382      -95     
- Misses         42279    42368      +89     
- Partials        5362     5379      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@LetLetMe
Copy link
Contributor

LGTM

Copy link
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit e876bed into apache:develop Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix message buffer not release and dispatch thread exit in tiered storage
5 participants