Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: SDAP-TODO: feat: S3 obj store #43

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

wphyojpl
Copy link
Contributor

  • add class to store tile blob in S3 in addition to Cassandra
  • update configuration to accept either S3 or Cassandra
  • refactor main method to avoid code duplication
  • TODO: add test case
  • TODO: AWS credentials

How SDAP handles S3 credentials

@frankinspace
Copy link

This was the "old" ingest code that was able to write to S3 instead of cassandra: https://github.com/apache/incubator-sdap-ningester/blob/master/src/main/java/org/apache/sdap/ningester/writer/S3Store.java

The analysis side as you see is able to read data from S3 instead of cassandra. I think @jjacob7734 might have worked on an instance of SDAP where that was configured.

As far as credentials go, it all uses the boto3 library so you can provide credentials in a number of different ways:
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html
I don't recall off the top of my head but typically they would be provided either through environment variables or a ~/.aws/credentials file on the node running the code.

@jjacob7734
Copy link

Adding S3 as a datastore option was work done by David Silvan, a summer intern at JPL, in Summer of 2017. I think he worked primarily with @ngachung on that. @ngachung , Thomas Huang, @fgreg and I received an email from David on 8/9/2017 in which he attached some benchmarks comparing the S3 datastore to Cassandra. It looks like at that time his S3 implementation was 2x to 5x (maybe 3x on average) slower than Cassandra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants