Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Iceberg] Support custom delete sql for sink savemode #8094

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Nov 21, 2024

Purpose of this pull request

[Iceberg] Support custom delete sql for sink savemode

Does this PR introduce any user-facing change?

Add new config

How was this patch tested?

Added

Check list

@hailin0 hailin0 force-pushed the dev-support-iceberg-delete-sql branch 2 times, most recently from 6d32ff1 to 555d50c Compare November 21, 2024 05:14
@hailin0 hailin0 force-pushed the dev-support-iceberg-delete-sql branch from 555d50c to 5b67e23 Compare November 21, 2024 12:45
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
LGTM

@davidzollo davidzollo merged commit 29ca928 into apache:dev Nov 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants