[Improve][API] Unified tables_configs and table_list #8100
+291
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @hailin0 |
Hisoka-X
reviewed
Nov 21, 2024
| @@ -56,4 +58,10 @@ public interface CatalogOptions { | |||
| .withDescription( | |||
| "The table names RegEx of the database to capture." | |||
| + "The table name needs to include the database name, for example: database_.*\\.table_.*"); | |||
|
|
|||
| Option<List<Map<String, Object>>> TABLE_LIST = | |||
There was a problem hiding this comment.
add some comments for devs about when to use table_list or table_configs?
Hisoka-X
changed the title
hailin0
reviewed
Nov 21, 2024
| schema { | ||
| table = "database.schema.table1" | ||
| schema_first = false | ||
| comment = "comment" |
There was a problem hiding this comment.
Move table, schema first, comment outside of schema?
There was a problem hiding this comment.
it came from #5628, this pr doesn't change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Currently, the attributes of Seatunnel multi-table configuration are table_list and tables_configs. They are distributed in their respective connectors and are confusing to use. Therefore, it is recommended to unify them.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.