-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added EXTRACT_URL_PARAMETER to Doris parsing support (#31508) #33571
base: master
Are you sure you want to change the base?
Conversation
- added test - added parser g4 in `extractUrlParameterFunction` - added visitor logic - ran spotless - ran (though will check again once committed and do a full test) ``` cd test/it/parser/ mvn -DskipTests=true generate-sources compile install -q cd parser/sql/dialect/doris/ mvn test -Dit.test=InternalDorisParserIT ``` Question - do we collapse two consecutive changes? So ``` // DORIS ADDED END // DORIS ADDED BEGIN ``` would be ``` ```
Will check the test failures. Looks like the combo:
doesn't fully test as expected. Currently fully testing on my test server. |
found the correct test indexes, will commit tomorrow |
Could complete full test cycle on test machine, next is to incorporate latest upstream changes and should be OK for final review |
Ready for review |
Hi @danigiri, can you solve code conflict? |
Sure, it is probably the release notes have drifted |
@strongduanmu can you check? release notes should be OK now |
XML test files have drifted since the PR was created, will resolve conflicts tomorrow morning |
Continuing with Doris parsing support.
In this case adding support for
EXTRACT_URL_PARAMETER
see https://doris.apache.org/docs/sql-manual/sql-functions/string-functions/extract-url-parameter
No equivalent mysql function i could find.
Continues to address #31508
Changes proposed in this pull request:
extractUrlParameterFunction
Question
would be
and have a final terminating
// DORIS ADDED END
at the end
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.mvn spotless:apply -Pcheck
mvn test -Dit.test=InternalDorisParserIT
inshardingsphere/parser/sql/dialect/doris
(need to specify it.test)SELECT EXTRACT_URL_PARAMETER('http://foo.com/?bar=baz','bar')