#201: Add quote to password examples #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OyvindLGjesdal
force-pushed
the
quote-ini-password
branch
from
2533a67 to
731e550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced the issue in apache/shiro#1385 when following the docs and thought I would try to to find the relevant entries in the docs and updating the examples in #201
fixes #201
Don't know if there should also be a note that the password has to be quoted, or if the example change is enough.
Does the change in src/site/content/configuration.adoc also makes sense with quotes, given the ... and the extra roles strings, looking at the note for permissionDefinition, I guess that quoting the password related parameters, before role, is how it should be done?