Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17466: Inform 9x users about upcoming change to solrcloud default mode #2728

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Sep 29, 2024

https://issues.apache.org/jira/browse/SOLR-17466

Description

Let 9x users know about bin/solr start being cloud mode by default and that they need --standalone in 10.

Solution

Warnings

Tests

bats

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

solr/bin/solr Outdated Show resolved Hide resolved
Co-authored-by: Jan Høydahl <[email protected]>
@epugh
Copy link
Contributor Author

epugh commented Oct 2, 2024

Thanks @janhoy that is a great improvement....

Copy link

@patrbraun patrbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me. Could maybe use a line return after to increase visibility.

@epugh
Copy link
Contributor Author

epugh commented Oct 10, 2024

Working for me. Could maybe use a line return after to increase visibility.

Done!

@epugh
Copy link
Contributor Author

epugh commented Oct 10, 2024

I don't think users care about a warning message so skipping CHANGES.txt

@epugh epugh merged commit 504d703 into apache:branch_9x Oct 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants