Skip to content

Commit

Permalink
add todo ticket
Browse files Browse the repository at this point in the history
  • Loading branch information
xinrong-meng committed Nov 22, 2024
1 parent 611598f commit ebbd498
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions python/pyspark/sql/connect/dataframe.py
Original file line number Diff line number Diff line change
Expand Up @@ -1785,6 +1785,7 @@ def transpose(self, indexColumn: Optional["ColumnOrName"] = None) -> ParentDataF
)

def argument(self) -> Column:
# TODO(SPARK-50393): Implement this method
raise PySparkNotImplementedError(
errorClass="NOT_IMPLEMENTED",
messageParameters={"feature": "argument()"},
Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/sql/tests/connect/test_parity_udtf.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def test_udtf_with_analyze_using_file(self):
def test_udtf_access_spark_session(self):
super().test_udtf_access_spark_session()

@unittest.skip("Spark Connect does not support df.argument()")
@unittest.skip("TODO(SPARK-50393): support df.argument() in Spark Connect")
def test_df_argument(self):
super().test_df_argument()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,10 @@ class DataFrameSuite extends QueryTest
Row("1", 1) :: Nil)
}

test("df.argument") {
assert(spark.range(1).argument().isInstanceOf[Column])
}

test("filterExpr") {
val res = testData.collect().filter(_.getInt(0) > 90).toSeq
checkAnswer(testData.filter("key > 90"), res)
Expand Down

0 comments on commit ebbd498

Please sign in to comment.