[SPARK-47583][CORE] SQL core: Migrate logError with variables to structured logging framework #45969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gengliangwang here is the structured logging migration for |
gengliangwang
approved these changes
Apr 11, 2024
dtenedor
changed the title
gengliangwang
approved these changes
Apr 23, 2024
Comment on lines
362
to
365
| val plans = | ||
| sideBySide(currentPhysicalPlan.treeString, newPhysicalPlan.treeString).mkString("\n") | ||
| logOnLevel(log"Plan changed:\n" + | ||
| log"${MDC(QUERY_PLAN, plans)}") |
There was a problem hiding this comment.
Suggested change
| val plans = | |
| sideBySide(currentPhysicalPlan.treeString, newPhysicalPlan.treeString).mkString("\n") | |
| logOnLevel(log"Plan changed:\n" + | |
| log"${MDC(QUERY_PLAN, plans)}") | |
| lazy val plans = | |
| sideBySide(currentPhysicalPlan.treeString, newPhysicalPlan.treeString).mkString("\n") | |
| logOnLevel(log"Plan changed:\n${MDC(QUERY_PLAN, plans)}") |
| @transient private val logOnLevel: ( => MessageWithContext) => Unit = | ||
| conf.adaptiveExecutionLogLevel match { | ||
| case "TRACE" => | ||
| def fn(log: => LogEntry): Unit = logTrace(log.message) |
There was a problem hiding this comment.
There is a logTrace accepting MessageWithContext now.
gengliangwang
approved these changes
Apr 24, 2024
|
Thanks, merging to master |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…ctured logging framework ### What changes were proposed in this pull request? Migrate logError with variables of the sql/core module to structured logging framework. This transforms the logError entries of the following API ``` def logError(msg: => String): Unit ``` to ``` def logError(entry: LogEntry): Unit ``` ### Why are the changes needed? To enhance Apache Spark's logging system by implementing structured logging. ### Does this PR introduce _any_ user-facing change? Yes, Spark core logs will contain additional MDC ### How was this patch tested? Compiler and scala style checks, as well as code review. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45969 from dtenedor/log-error-sql-core. Authored-by: Daniel Tenedorio <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate logError with variables of the sql/core module to structured logging framework. This transforms the logError entries of the following API
to
Why are the changes needed?
To enhance Apache Spark's logging system by implementing structured logging.
Does this PR introduce any user-facing change?
Yes, Spark core logs will contain additional MDC
How was this patch tested?
Compiler and scala style checks, as well as code review.
Was this patch authored or co-authored using generative AI tooling?
No