Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert [SPARK-50230][SQL] Added logic to support reading unknown collation name as utf8_binary #48876

Conversation

vladanvasi-db
Copy link
Contributor

What changes were proposed in this pull request?

I propose reverting changes for new SQLConf entry which enables spark to read an invalid collation name as UTF8_BINARY.

Why are the changes needed?

Since the original changes may bring unwanted data corruption when a user writes in a table that has unknown collation and modifies its properties, the original PR must be reverted.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not applicable.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Nov 18, 2024
@vladanvasi-db
Copy link
Contributor Author

@MaxGekk please take a look at this one.

@vladanvasi-db vladanvasi-db force-pushed the vladanvasi-db/allow-reading-unknown-collations-as-utf8-binary-revert branch from 369eb2a to b017327 Compare November 18, 2024 13:13
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes may bring unwanted data corruption

@vladanvasi-db Could you explain in PR's description how this could happen.

@MaxGekk
Copy link
Member

MaxGekk commented Nov 21, 2024

@vladanvasi-db Could you fix tests, please:

[info] - group-by-all-mosha.sql *** FAILED *** (838 milliseconds)
[info]   group-by-all-mosha.sql
[info]   Expected "...   "expression" : "'[42.0]'",
[info]       "sourceType"...", but got "...   "expression" : "'[13.37]'",
[info]       "sourceType"..." Result did not match for query #4
[info]   SELECT i + 1, f / i, substring(s, 2, 3), extract(year from t), d / 2, size(a) FROM stuff
[info]   GROUP BY ALL ORDER BY 1, 3, 4, 5, 6, 2 (SQLQueryTestSuite.scala:663)

@vladanvasi-db vladanvasi-db force-pushed the vladanvasi-db/allow-reading-unknown-collations-as-utf8-binary-revert branch from b017327 to d366d27 Compare November 22, 2024 09:12
@MaxGekk
Copy link
Member

MaxGekk commented Nov 22, 2024

+1, LGTM. Merging to master.
Thank you, @vladanvasi-db.

@MaxGekk MaxGekk closed this in d5da49d Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants