Remove .*? from parser #48917
Closed
Remove .*? from parser #48917
+41
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I propose to remove .*? from parser rules.
Why are the changes needed?
.*? will match anything and in that case will consume comments and all garbage, we need to fix this to make queries like
set /*comment*/ ;work. This is a bug that we have from beginning of the parser and IMO should be fixed to work properly.Does this PR introduce any user-facing change?
Yes, fixing parser.
How was this patch tested?
Existing tests and added tests to come.
Was this patch authored or co-authored using generative AI tooling?
Yes.