[SPARK-51227][PYTHON][CONNECT] Fix PySpark Connect _minimum_grpc_version to 1.67.0
#49968
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
cloud-fan
approved these changes
Feb 16, 2025
dongjoon-hyun
added a commit
that referenced
this pull request
Feb 16, 2025
…sion` to 1.67.0 ### What changes were proposed in this pull request? This PR aims to fix PySpark Connect `_minimum_grpc_version` from 1.59.3 to 1.67.0 correctly. https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/python/docs/source/getting_started/install.rst?plain=1#L211 https://github.com/apache/spark/blob/c36916f7a112dc6c6505c12d68c3f63c5aa31db2/dev/spark-test-image/python-minimum/Dockerfile#L76 ### Why are the changes needed? It seems that we missed to this at - #44929 - #48524 ### Does this PR introduce _any_ user-facing change? This will make it sure that PySpark Connect installation meets the minimum requirement correctly. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49968 from dongjoon-hyun/SPARK-51227. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 3f4ba72) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Thank you, @cloud-fan . Merged to master/4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix PySpark Connect
_minimum_grpc_versionfrom 1.59.3 to 1.67.0 correctly.spark/python/docs/source/getting_started/install.rst
Line 211 in c36916f
spark/dev/spark-test-image/python-minimum/Dockerfile
Line 76 in c36916f
Why are the changes needed?
It seems that we missed to this at
grpcio*andgrpc-javato 1.62.x #44929grpcio*to 1.67.0 andgrpc-javato 1.67.1 #48524Does this PR introduce any user-facing change?
This will make it sure that PySpark Connect installation meets the minimum requirement correctly.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.