mod_dav_svn: Use mod_dav's DAVBasePath setting #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The arm64 test failure here is interesting, it is likely to be unrelated to the code change. The arm64 support in GHA is new/experimental so it might be something random but the tests have failed twice. |
repository root path, allowing SVN to be configured via LocationMatch
like:
<LocationMatch ^/repos/svn(.*)>
DAV svn
SVNParentPath /srv/repos
DAVBasePath /repos
</LocationMatch>
by mapping URL path "/repos/svnfoo" to the filesystem path of
"/srv/repos/svnfoo". This partially addresses issues like SVN-4790
(with minimal added complexity), though does not provide as much
flexibility as discussed in SVN-2679.
* subversion/mod_dav_svn/mod_dav_svn.c
(dav_svn__get_root_dir): Retrieve and return the setting from
DavBasePath via dav_get_base_path() where that API is available
and DavBasePath is configured.
(dav_svn__translate_name): Use dav_svn__get_root_dir() to determine
the repos root for the same reason.
Try to capture tests.log if the tests fail.
notroj
force-pushed
the
mod_dav_svn-use-davbasepath
branch
from
e53e4f6 to
3fbe60a
Compare
dsahlberg-apache-org
suggested changes
Feb 21, 2025
There was a problem hiding this comment.
I already added something very similar in r1923964/r1923965, didn't notice this was already included in this PR.
There was a problem hiding this comment.
Ah great, looks perfect.
| @@ -781,6 +781,15 @@ const char * | |||
| dav_svn__get_root_dir(request_rec *r) | |||
| { | |||
| dir_conf_t *conf; | |||
| const char *base; | |||
|
|
|||
There was a problem hiding this comment.
Any particular reason why base isn't declared within the #if block?
If compiled with < 20211221.28, there is a compiler warning about an unused variable.
|
您的来信已收到
|
Yeah, I will add a CI workflow against an HTTPD trunk build to get this tested, it'd be a useful thing to have anyway. |
|
@notroj Do you want to add the CI workflow before you commit this or can we go ahead and commit and close the PR? |
|
您的来信已收到
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this mod_dav API is only present in httpd trunk (currently).