chore(antd): straightening out button import paths #29969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,7 +137,8 @@ const actionButtonsStyle = theme => css` | |||
| } | |||
| `; | |||
|
|
|||
| const StyledUndoRedoButton = styled(AntdButton)` | |||
| const StyledUndoRedoButton = styled(Button)` | |||
| // TODO: check if we need this. | |||
There was a problem hiding this comment.
It's used in the dashboard header in edit mode ->
There was a problem hiding this comment.
oh, I meant the CSS below it ;) It might not need those overrides... but I'll circle back to that.
mistercrunch
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Just straightening out some wiring. Now the Superset "Button" imports directly from AntD, and the other Button instances in the code import from the Superset component instead of the AntD base component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION