fix: helm chart deploy to open PRs to now-protected gh-pages branch #31155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaning up the mess I created by deleting the `gh-pages` branch by mistake while deleting hundreds of stale branches in the repo. The changes here make it such that pushing a new helm chart version will now open a PR against the now-protected `gh-pages` branch, require a review and merge to be deployed.
github-actions
bot
added
the
github_actions
3 tasks
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
rusackas
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Huh... don't think I've seen it show this before. Neat!
rusackas
reviewed
Nov 26, 2024
| @@ -1,4 +1,4 @@ | |||
| name: Lint and Test Charts | |||
| name: "Helm: lint and test charts" | |||
There was a problem hiding this comment.
Nice improvement... I'll bet half the people that see this think it's eslint and dataviz charts :)
There was a problem hiding this comment.
It's been bugging me for a moment. Making the repo a better place, one line at a time.
rusackas
reviewed
Nov 26, 2024
| name: Release Charts | ||
| # This workflow automates the release process for Helm charts. | ||
| # The workflow creates a new branch for the release and opens a pull request against the 'gh-pages' branch, | ||
| # allowing the changes to be reviewed and merged manually. |
There was a problem hiding this comment.
We should probably expand the code owners for these reviews... maybe you want to be one?
rusackas
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the mess I created by deleting the
gh-pagesbranch by mistake while deleting hundreds of stale branches in the repo.The changes here make it such that pushing a new helm chart version will now open a PR against the now-protected
gh-pagesbranch, require a review and merge to be deployed.Testing now with:
Logs / iterations can be followed here -> https://github.com/apache/superset/actions/workflows/superset-helm-release.yml
The approach here is to:
helm-publish-{SHA}chart-releaser-actionthat the branch we're working with is NOTgh-pages(protected, can't push there), but instead is a temporary branch