Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FilterBar): move the "Add/edit filters" button in the FilterBar to the settings menu #31290

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore(FilterBar): move the "Add/edit filters" button in the FilterBar to the settings menu #31290

wants to merge 3 commits into from
+54 −136

Conversation

alexandrusoare
Copy link
Contributor

Fixes #30876

SUMMARY

Filter Bar: Move "Add/Edit Filters" to the Gear Icon

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

Before
image

After
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@alexandrusoare alexandrusoare marked this pull request as ready for review December 4, 2024 15:09
@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Dec 4, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje Awaiting requested review from kgabryje

@kasiazjc kasiazjc Awaiting requested review from kasiazjc

@geido geido Awaiting requested review from geido

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dashboard:native-filters Related to the native filters of the Dashboard review:checkpoint Last PR reviewed during the daily review standup size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Bar: Move "Add/Edit Filters" to the Gear Icon
2 participants
@alexandrusoare @michael-s-molina