fix: ISO updated for overseas #32719
Conversation
ISO updated for overseas Source : https://www.iso.org/obp/ui/en/#iso:code:3166:FR Effective date of change : 2021-11-25
ISO updated for overseas Source : https://www.iso.org/obp/ui/en/#iso:code:3166:FR Effective date of change : 2021-11-25
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
xavier-GitHub76
changed the title
|
Wondering if this could be a breaking change for some. Good to align with ISO-standard though. Can we add a short note to |
Add alert for apache#32719
|
I add the alert in UPDATING.md |
There was a problem hiding this comment.
I appreciate the fix (and the note in Updating) but these changes need to be made in the Jupyter notebook, otherwise the downstream edits you made to the GeoJSON will be overwritten by the next run of the notebook. I made a blog post that goes into how to do this, let me know if it helps (or not): https://preset.io/blog/how-and-when-and-why-to-update-apache-supersets-country-maps/
SUMMARY
ISO updated for overseas
Source : https://www.iso.org/obp/ui/en/#iso:code:3166:FR
Effective date of change : 2021-11-25
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Some ISO are depecated
TESTING INSTRUCTIONS
Create a chart based on Country Map and
a dataset
for example :
SELECT 'FR-GF' as "iso", 'old iso' as "comment", 10 as value
union
SELECT 'FR-973' as "iso", 'current iso' as "comment", 20 as value
Country Map must return the value 20 for the overseas Guyane