Handle failed tomcat war deployment (status OK but body FAIL) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
May 24, 2017
| tomcatHttpStatusError = Tomcat a retourn\u00E9 un code HTTP en erreur: {0}, raison: {1} |
There was a problem hiding this comment.
Isn't that wrong? As far as I know French always puts a space before the colon.
There was a problem hiding this comment.
correct. I just added the space.
michael-o
reviewed
May 24, 2017
| tomcatHttpStatusError = Tomcat a retourn\u00E9 un code HTTP en erreur : {0}, raison: {1} |
There was a problem hiding this comment.
raison is missing the trailing space too
|
@michael-o do you think I should add tests ? this is a basic feat. thx for the review |
|
Absolutely, if you think you can! Don't forget to squash your commits! |
|
@olamy @michael-o Are there any plans to release new version of this plugin? |
|
Wow, I completely forgot this. Will have a look later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html a failed deploy will trigger a body with status code 200 but with body response starting with FAIL (i18n)
this patch adds the FAIL body response handler for en/fr languages
unsure if tests are really needed (?)