Tc9.x Initial suport for Tomact9 #30
Conversation
* From tomcat8-maven-plugin to tomcat9-maven-plugin * From tomcat8-war-runner to tomcat9-war-runner
|
This only conflicting here because need of new version of maven |
This was causing the artefact build to fail as it ignored the \ escapes.
Setup the webapp like it would be normally and let Tomcat handle everything. There is one hack to work around a hack in Weld’s WebAppBeanArchiveScanner, which explicitly looks for WEB-INF/classes.
|
@poolborges thank you for your work on this! This is a useful thing to have. I've just made a PR on your repo, so I'm just adding the link here to complete the loop. |
Tomcat is headless. It’s a pain on macOS if this isn’t set.
This fixes a bug where conflicting files in jars would be loaded instead of the same file in the module’s build directory.
Improvements to Tomcat 9 support
| return new JarResource( this, // | ||
| getPath(), // | ||
| filePath, // | ||
| url.getPath().substring( 0, idx ), // | ||
| jarEntry, // | ||
| "", // | ||
| null ); | ||
| */ | ||
|
|
||
| JarResourceSet jr = new JarResourceSet(context.getResources(), getPath(), filePath, getPath()); |
There was a problem hiding this comment.
original internal path is "", and set to getPath(), please verify as "/", or getPath().
There was a problem hiding this comment.
@liudongmiao I think that particular line might have gone in the merge from my code... if not, could you please explain what you're seeing that's wrong here? The JarResourceSet parameters are a little opaque to me, so I'd appreciate some more explanation!
There was a problem hiding this comment.
Sorry for outdated.
Yes, for the code, it's changed from getPath() to "/" in commit 7f26908.
And the internal path is always "/" now.
A set of commit to add plugin version for tomcat 9