Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding Parallel Deployment section of Tomcat Docs #832

Closed
wants to merge 9 commits into from

Conversation

usmazat
Copy link

@usmazat usmazat commented Mar 19, 2025

Added a paragraph in the Parallel deployment section of Tomcat docs to include an example of getting current webappVersion via property
Original example was provided by @ChristopherSchultz

usmazat added 2 commits March 18, 2025 16:47
Added an example about geting current webapp version number in a servlet
@markt-asf
Copy link
Contributor

If you mention one request attribute you should mention them all. You might need a table.

@usmazat
Copy link
Author

usmazat commented Mar 20, 2025

If you mention one request attribute you should mention them all. You might need a table.

I put together a table of attributes. wasn't sure where to put it so I created a separate xml document and put a link in a context.xml

@markt-asf
Copy link
Contributor

I like the idea. I don't think we have a list of ServletContext attributes in a single place. The implementation needs a few tweaks to fit in with how we build the Tomcat docs. I'll re-work this using systemprops.xml as a basis.

Also, the list needs to be limited to ServletContext attributes. Other values - such as system properties - are documented elsewhere.

@usmazat
Copy link
Author

usmazat commented Mar 26, 2025

I like the idea. I don't think we have a list of ServletContext attributes in a single place. The implementation needs a few tweaks to fit in with how we build the Tomcat docs. I'll re-work this using systemprops.xml as a basis.

Also, the list needs to be limited to ServletContext attributes. Other values - such as system properties - are documented elsewhere.

Thanks @markt-asf , please let me know if there is anything I need to do on my part

markt-asf added a commit that referenced this pull request Mar 26, 2025
markt-asf added a commit that referenced this pull request Mar 26, 2025
markt-asf added a commit that referenced this pull request Mar 26, 2025
markt-asf added a commit that referenced this pull request Mar 26, 2025
@markt-asf
Copy link
Contributor

Nothing to do on your part. Thanks for the work you put into this. I've added a new runtime attribute section to the configuration documentation that documents the request and servlet context attributes.

@markt-asf markt-asf closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants