-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Windows] Workaround for error in Findzstd.cmake #17283
Draft
Lunderberg
wants to merge
15
commits into
apache:main
Choose a base branch
from
Lunderberg:cmake_windows_missing_zlib_error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CI][Windows] Workaround for error in Findzstd.cmake #17283
Lunderberg
wants to merge
15
commits into
apache:main
from
Lunderberg:cmake_windows_missing_zlib_error
Commits on Aug 19, 2024
-
[CI][Windows] Workaround for error in Findzstd.cmake
This is a workaround for an upstream LLVM issue [0], which looks to be caused by the `CMAKE_INSTALL_LIBDIR` variable is used before definition. While there is an LLVM PR to resolve this fix [1], as of 2024-08-19 it has not yet been merged to LLVM. This change is intended to resolve the following error, which occurs during the CI build of TVM on Windows. ``` The system cannot find the file specified. CMake Error at C:/Miniconda/envs/tvm-build/conda-bld/tvm-package_1723747883202/_h_env/Library/lib/cmake/llvm/Findzstd.cmake:39 (string): string sub-command REGEX, mode REPLACE: regex "$" matched an empty string. Call Stack (most recent call first): C:/Miniconda/envs/tvm-build/conda-bld/tvm-package_1723747883202/_h_env/Library/lib/cmake/llvm/LLVMConfig.cmake:277 (find_package) cmake/utils/FindLLVM.cmake:47 (find_package) cmake/modules/LLVM.cmake:31 (find_llvm) CMakeLists.txt:565 (include) ``` [0] llvm/llvm-project#83802 [1] llvm/llvm-project#83807
Configuration menu - View commit details
-
Copy full SHA for c1a2781 - Browse repository at this point
Copy the full SHA c1a2781View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6788d48 - Browse repository at this point
Copy the full SHA 6788d48View commit details
Commits on Aug 20, 2024
-
Do not capture output in CI Windows pytest
If pytest captures the output, segfaults in a unit test prevent any output from being printed.
Configuration menu - View commit details
-
Copy full SHA for f784949 - Browse repository at this point
Copy the full SHA f784949View commit details -
Configuration menu - View commit details
-
Copy full SHA for af3073b - Browse repository at this point
Copy the full SHA af3073bView commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fa5ee2b - Browse repository at this point
Copy the full SHA fa5ee2bView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4252cec - Browse repository at this point
Copy the full SHA 4252cecView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce8fc4a - Browse repository at this point
Copy the full SHA ce8fc4aView commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for da1022c - Browse repository at this point
Copy the full SHA da1022cView commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3c2bc5a - Browse repository at this point
Copy the full SHA 3c2bc5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64bb4c5 - Browse repository at this point
Copy the full SHA 64bb4c5View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eeee23c - Browse repository at this point
Copy the full SHA eeee23cView commit details
Commits on Aug 28, 2024
-
The f32-to-f32 test case passed, so it's not an issue with all generated code. Trying a f16-to-f16 conversion to see if it's a problem with the existence of f16 arguments at all.
Configuration menu - View commit details
-
Copy full SHA for a2bd7de - Browse repository at this point
Copy the full SHA a2bd7deView commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1a4216f - Browse repository at this point
Copy the full SHA 1a4216fView commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 43498c4 - Browse repository at this point
Copy the full SHA 43498c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b7cef4 - Browse repository at this point
Copy the full SHA 7b7cef4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.