Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Windows] Workaround for error in Findzstd.cmake #17283

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Commits on Aug 19, 2024

  1. [CI][Windows] Workaround for error in Findzstd.cmake

    This is a workaround for an upstream LLVM issue [0], which looks to be
    caused by the `CMAKE_INSTALL_LIBDIR` variable is used before
    definition.  While there is an LLVM PR to resolve this fix [1], as of
    2024-08-19 it has not yet been merged to LLVM.
    
    This change is intended to resolve the following error, which occurs
    during the CI build of TVM on Windows.
    
    ```
    The system cannot find the file specified.
    CMake Error at C:/Miniconda/envs/tvm-build/conda-bld/tvm-package_1723747883202/_h_env/Library/lib/cmake/llvm/Findzstd.cmake:39 (string):
      string sub-command REGEX, mode REPLACE: regex "$" matched an empty string.
    Call Stack (most recent call first):
      C:/Miniconda/envs/tvm-build/conda-bld/tvm-package_1723747883202/_h_env/Library/lib/cmake/llvm/LLVMConfig.cmake:277 (find_package)
      cmake/utils/FindLLVM.cmake:47 (find_package)
      cmake/modules/LLVM.cmake:31 (find_llvm)
      CMakeLists.txt:565 (include)
    ```
    
    [0] llvm/llvm-project#83802
    [1] llvm/llvm-project#83807
    Lunderberg committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c1a2781 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6788d48 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Do not capture output in CI Windows pytest

    If pytest captures the output, segfaults in a unit test prevent any
    output from being printed.
    Lunderberg committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    f784949 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    af3073b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    fa5ee2b View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    4252cec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ce8fc4a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. Add another debug print

    Lunderberg committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    da1022c View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Added more debug prints

    Lunderberg committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    3c2bc5a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64bb4c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    eeee23c View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Try a f16-to-f16 test case

    The f32-to-f32 test case passed, so it's not an issue with
    all generated code.  Trying a f16-to-f16 conversion to see if it's a
    problem with the existence of f16 arguments at all.
    Lunderberg committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a2bd7de View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    1a4216f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Lint fix

    Lunderberg committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    43498c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b7cef4 View commit details
    Browse the repository at this point in the history