Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WICKET-7135 Work on deprecation warnings #1049

Merged
merged 3 commits into from
Dec 2, 2024
Merged

WICKET-7135 Work on deprecation warnings #1049

merged 3 commits into from
Dec 2, 2024

Conversation

aldaris
Copy link
Contributor

@aldaris aldaris commented Nov 28, 2024

This PR attempts to address most of the deprecated call warnings shown during compilation time. There are a still couple of them left that are a bit more tricky to handle:

  • DebugSettings#isOutputMarkupContainerClassName usage in Page - the output strategy is not simple to implement given that Page currently only embeds the classname as a separate comment element, not sure what it should tie to otherwise
  • Cookie#setComment, #setVersion usages - don't think anything really needs to be done about these
  • CachingResourceStreamLocator#locate - there is a missing @deprecated annotation. Without proper JavaDoc explanation I didn't want to go down a road for this one
  • AccessController usages in JavaSerializer - could just replace them with Runnable#run I suppose, but wasn't sure whether security manager support was there for something specific

bitstorm
bitstorm requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@bitstorm bitstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Do you have a JIRA account to create a related issue?

@bitstorm bitstorm changed the title Work on deprecation warnings WICKET-7135 Work on deprecation warnings Dec 2, 2024
@bitstorm bitstorm merged commit da01909 into apache:master Dec 2, 2024
2 checks passed
bitstorm pushed a commit that referenced this pull request Dec 2, 2024
@aldaris @bitstorm
WICKET-7135 Work on deprecation warnings (#1049)
a7222a3 
* Migrate new Locale constructor invocations to Locale.of calls

* Migrate new URL constructor invocations to URI#toURL

* Migrate deprecated API calls to their replacements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitstorm bitstorm bitstorm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldaris @bitstorm