[YUNIKORN-2448] Implemented licenses modal #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 73.07% 73.07%
=======================================
Files 1 1
Lines 26 26
=======================================
Hits 19 19
Misses 4 4
Partials 3 3 ☔ View full report in Codecov by Sentry. |
chia7712
reviewed
Mar 5, 2024
- Update angular.json to set LICENSE as asset - update licenses-modal.component.ts to get LICENSE file for modal - removed example-licenses.txt
|
@dcoric thanks for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds a menu option to display licenses used by the project. Clicking that menu option opens a modal dialog where all licenses are listed.
A list of licenses is generated on build time. For dev preview, a short example file is used.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2448
Questions?
Screenshots (if appropriate)