Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2449] add PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 to CI #176

Closed
wants to merge 2 commits into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Mar 7, 2024

What is this PR for?

Add PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 into yarn install command in CI

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-2449

How should this be tested?

Test in CI

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@chia7712
Copy link
Contributor

chia7712 commented Mar 7, 2024

the action of installing dependencies works well.

1m 33s
Run PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 yarn install
  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1 yarn install
  shell: /usr/bin/bash -e {0}
yarn install v1.22.21
[1/4] Resolving packages...
[2/4] Fetching packages...
warning [email protected]: The engine "pnpm" appears to be invalid.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 93.68s.

will merge it.

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chia7712 pushed a commit that referenced this pull request Mar 7, 2024
@craigcondit
Copy link
Contributor

This seems to have been done elsewhere. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants